Review of "Stocks Extension" version 34

Details Page Preview

Stocks Extension brings stock quotes to your GNOME Shell Panel

Extension Homepage
https://github.com/cinatic/stocks-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. You cannot import `Gtk` into the shell process: - line 4 components/buttons/buttonGroup.js - line 4 components/flatList/flatList.js https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 2. You cannot call functions in global scope (same as init): - line 9 prefs.js - line 43 extension.js https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. `ExtensionPreferences.lookupByURL()` is a bad practice when you have these in the entry point: - `this.getSettings()` - `this.path` 4. Don't use `imports.`: - line 5 components/screens/stockNewsListScreen/stockNewsListScreen.js - line 4 components/screens/stockOverviewScreen/stockOverviewScreen.js - line 7 components/stocks/menuStockTicker.js