Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
35 | Rejected |
34 | Active |
33 | Active |
32 | Rejected |
31 | Active |
30 | Active |
29 | Active |
28 | Active |
27 | Active |
26 | Active |
25 | Active |
24 | Active |
23 | Active |
22 | Active |
21 | Active |
20 | Rejected |
19 | Active |
18 | Active |
17 | Active |
16 | Rejected |
15 | Inactive |
14 | Active |
13 | Active |
12 | Active |
11 | Active |
10 | Active |
9 | Active |
8 | Active |
7 | Active |
6 | Rejected |
5 | Rejected |
4 | Rejected |
3 | Active |
2 | Active |
1 | Rejected |
1. Timeout should be removed in disable (line 147 net_speed.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Lang is a deprecated module. Please remove it for the next version: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#General_Advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html
Please take a look at https://github.com/hedayaty/NetSpeed/issues/131 I started this extension long ago. Just keeping up with gnome changes + volunteers helping me on this. That specific timer gets removed by itself because it returns GLib.SOURCE_REMOVE If there is a better way of resolving the font tearing, I would apply that. Thanks on the advice. I am more of a backend guy not really good at js. However, I will take a look at the new syntax.
> You MUST remove all active main loop sources in disable(), even if the callback function will eventually return `false` or `GLib.SOURCE_REMOVE`. For redraw issue: I cannot reproduce it on 41 (X11). You can ask that on: - discourse.gnome.org using the [extensions](https://discourse.gnome.org/tag/extensions) tag - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions