1. Use `ExtensionUtils.getSettings()` instead of creating your own custom functions (line 61 utils.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 2. Why do you have two xml files for schema? 3. Rejected because you need to make `settings` (line 10 prefs.js) local and move it to `buildPrefsWidget`, so it gets cleaned out after window close. You can send it to `_updateProviderTab()` as function argument if that function needs it. 4. Also do this in disable: ```js panelEntry = null; ``` 5. To open settings only use `ExtensionUtils.openPrefs()`. Remove line 74-75 (extension.js). 6. Rejected because you need to remove the timeout in disable (extension.js line 120): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

Thanks for the review! There are two XML files for schema because the original extension had one separate XML file for each wallpaper provider. The XML files were likely kept separate to make it easily extensible. I opted to keep it extensible that way, even though there is only one provider now.