Review of "Wallpaper Changer Continued" version 2

Details Page Preview

Fork of wallpaper-changer@jomik.org, updated for Gnome 4

Extension Homepage
https://github.com/Ghostkeeper/gnome-wallpaper-changer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
Thanks! You should also null out `panelEntry.timer` in disable because that's not a reference. also after line 115 (extension.js)
Ghostkeeper posted a review
The `resetTimer()` function (after line 115) already nulls out `timer` if the timer is not running or expired. If the timer is running, it replaces it with a new timer. I'll null it in the `disable` function, right before the `destroy()` call. I must admit that this part of object-oriented JavaScript is magic to me, so I'll take your word on it that this is necessary.