Review of "Compiz windows effect" version 15

Details Page Preview

Compiz wobbly windows effect ----------------------------------- Video ----------------------------------- https://youtu.be/G8bAVIB9A7A

Extension Homepage
https://github.com/hermes83/compiz-windows-effect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
You cannot create objects in `init()` (extension.js line 40) if you are not returning it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null it out in disable. You need to remove line 43-53, if you want to return `CompizWindowsEffectExtension` instance in init(). Also line 59 should be moved to `CompizWindowsEffectExtension.enable()` and null out in `CompizWindowsEffectExtension.disable()` if you did that.