Review of "Compiz windows effect" version 22

Details Page Preview

Compiz wobbly windows effect thanks to compiz plugin engine. Does NOT requires any external library NB: In case of update error please restart Gnome Shell (on Xorg press ALT+F2 then write r and press enter, on Wayland end the session and log in again) ----------------------------------- Video ----------------------------------- https://youtu.be/G8bAVIB9A7A

Extension Homepage
https://github.com/hermes83/compiz-windows-effect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
You cannot do `run_dispose()` in extensions: - line 113 src/effects/resize.js - line 170 src/effects/wobbly.js > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose
hermes83 posted a review
It's really strange because the lines were already present in the old version, respectively at line 376 and 562 of the extension.js file. The extension.js file has now been simply split. If I'm not mistaken, you had reviewed it back in April of this year. In any case, I'll remove them, thanks.
JustPerfection posted a review
We had some extensions using that before which we don't want it in extensions anymore. and I'm reviewing all the lines (not only the diffs) for 45 extensions because the old code should be compatible with the current ego guidelines.