Review of "Reminder Alarm Clock" version 41

Details Page Preview

The reminder alarm clock will remind you of an important event at the appointed time.

Extension Homepage
https://github.com/nE0sIghT/ReminderAlarmClock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Yuri Konotopov auto- active
JustPerfection posted a review
1. You forgot to use `ExtensionUtils.initTranslations()` in prefs.js. 2. Use `ExtensionUtils.getSettings()` instead of line 53-63 extension.js and 25-34 prefs.js: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 3. `Tweener` is a deprecated module. Please remove it for the next version. You can use `ease()` instead. For example: ```js widget.ease({ x: newX, y: 10, opacity: 100, duration: 2000, mode: Clutter.AnimationMode.EASE_OUT_BOUNCE, onComplete: () => { log('Animation is finished'); } }); ``` More about animation mode: https://gjs-docs.gnome.org/clutter10~10_api/clutter.animationmode 4. Please remove unnecessary logs: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 5. No need to check the shell version in line 377 (extension.js) since your extension is not compatible with 3.x. 6. What's the reason for not removing the main loop id with `GLib.Source.remove(this.id)` in line 26-30 (alarm_clock.js)? https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions