Review of "Reminder Alarm Clock" version 47

Details Page Preview

The reminder alarm clock will remind you of an important event at the appointed time.

Extension Homepage
https://github.com/nE0sIghT/ReminderAlarmClock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. This is 45 only, so line 373 check is not needed. 2. Please don't store anything in the default class you are exporting since they won't get garbage collected after window close (line 14 `prefs.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You have two options: a. Make the properties local to `getPreferencesWidget()` and pass it to the functions needing it. b. Null out properties on window close request: ```js window.connect('close-request', () => { // null out here }); ``` btw, you can attach the settings object to the window as we did in this example (it can avoid settings instance getting garbage collected before window close): [GNOME Extensions Guide: Preferences](https://gjs.guide/extensions/development/preferences.html#prefs-js)
Yuri Konotopov posted a review
Thanks for review!