Review of "EasyEffects Preset Selector" version 8

Details Page Preview

Quickly show and load EasyEffects Presets

Extension Homepage
https://github.com/ulville/eepresetselector

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What is `setTimeout()` in line 193 (extension.js).
ulville posted a review
For flatpak version of EasyEffects; There is a ~1s delay between asking EasyEffects to load the preset user has selected and EasyEffects to update the dconf value we read to update the menu. In some cases where user clicks the panel button again, too quick after selecting a preset, we read the unupdated old value and we refresh the menu with a wrong information. To prevent this, we measure the time between the last time user has selected a preset and now, if it's less than 1 sec we wait for the remaining time before reading the value from dconf and refreshing the menu with actual information. This happens in an async function and doesn't interrupt the ui or other functions. It also only gets triggered if the user opens the menu again too quickly after selecting a preset.
JustPerfection posted a review
I think `setTimeout()` is 42 only.
JustPerfection waiting for author
I think you should remove <=41 if you want to use that.
ulville posted a review
I didn't know that. I've uploaded a new version where I use setTimeout() only if GNOME version is >= 42. Otherwise I use Mainloop.timeout_add(). This one can be rejected
JustPerfection rejected