Review of "Notification Banner Reloaded" version 5

Details Page Preview

Configure notification banner position and animation to your liking. Version 9: Gnome 45 changes by mannjani@github Version 10: mannjani@github added a test button inside prefs

Extension Homepage
https://github.com/marcinjakubowski/notification-position-reloaded

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
Please remove `patcher` and do it without `eval` for the next version.
Marcin Jakubowski posted a review
how do i do that without copy/pasting entire bodies of these functions? the whole point of patcher is to make sure I am not rewriting these functions in their entirety, just patching the x,y coordinates of the banner while keeping all the other logic intact
JustPerfection posted a review
You can create a function for each one of those patches. You can also create a module for those functions if you want to organize them. The thing is you shouldn't use eval when you can do it in a simple function form.