Review "Notification Banner Reloaded" version 1

Review of "Notification Banner Reloaded" version 1

Details Page Preview

Notification Banner Reloaded

Configure notification banner position and animation to your liking. Version 9: Gnome 45 changes by mannjani@github Version 10: mannjani@github added a test button inside prefs

Extension Homepage: https://github.com/marcinjakubowski/notification-position-reloaded

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
14	Active
13	Active
12	Active
11	Active
10	Active
9	Rejected
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected December 7, 2021

1. line 149 (extension.js) should be inside enable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Also do this on disable: this._settings = null; 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Use ExtensionUtils.getSettings() instead of creating your own custom function: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions

Marcin Jakubowski posted a review December 7, 2021

Thanks a lot for the review! I wasn't sure how to properly follow-up, so I uploaded the updated version as version 2, hope that's fine.