Review of "Notification Banner Reloaded" version 18

Details Page Preview

Configure notification banner position and animation to your liking. Version 9: Gnome 45 changes by mannjani@github Version 10: mannjani@github added a test button inside prefs

Extension Homepage
https://github.com/marcinjakubowski/notification-position-reloaded

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:37
        getPreferencesWidget() {
            let frame = new Gtk.Box();
            let widget = new Preferences(this.getSettings());
            frame.append(widget.main);
            if (frame.show_all)
                frame.show_all();
            return frame;
        }

All Versions

Version Status
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled`.