Review of "Simple Timer" version 3

Details Page Preview

Simple Timer is a GNOME Shell Extension that adds a timer to your panel.

Extension Homepage
https://github.com/MajortomVR/simple-timer-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
You forgot to null out `this.timer` in disable.
Majortom posted a review
That would prevent the timer from working on the lock-screen. Do i need back the timer up on the disk, or is there some other way? I am a bit confused, as i haven't found examples for best practice in this case. Thanks for your time!
JustPerfection posted a review
You are using `unlock-dialog` in session modes. So, disable won't be called in unlock dialog.
JustPerfection posted a review
btw, if you want to learn about session modes read this page: https://gjs.guide/extensions/topics/session-modes.html
Majortom posted a review
It still called disable for me when testing in the past. I did some further testing now, and it turns out that this behaviour only occurs for the first time when the screen is locked & unlocked. It works correctly at the second time. Aug 17 18:06:48 gnome-shell[2203]: INIT Aug 17 18:06:48 gnome-shell[2203]: ENABLE [LOCK] Aug 17 18:07:06 gnome-shell[2203]: DISABLE Aug 17 18:07:06 gnome-shell[2203]: ENABLE Aug 17 18:07:06 gnome-shell[2203]: DISABLE Aug 17 18:07:06 gnome-shell[2203]: ENABLE Aug 17 18:07:06 gnome-shell[2203]: DISABLE Aug 17 18:07:06 gnome-shell[2203]: ENABLE Aug 17 18:07:06 gnome-shell[2203]: DISABLE Aug 17 18:07:06 gnome-shell[2203]: ENABLE [UNLOCK] [LOCK] [UNLOCK] Maybe it has somehow to do with restarting gnome, at least it seems to be working correctly otherwise. Thanks again, i'll upload a new version now.
JustPerfection posted a review
Did you test it on 42?
Majortom posted a review
Yes, 42.3 on Fedora. Did some testing with a Ubuntu Virtual Machine, and it works correctly there. The difference is that i use Xorg here, but the Ubuntu Machine where everything works correctly uses Wayland.