GNOME Shell Extensions

Review of "Simple Timer" version 18

Details Page Preview

Simple Timer

by Majortom

Simple Timer is a Gnome Shell Extension that adds a Timer to the Panel.

Extension Homepage
https://github.com/MajortomVR/simple-timer-extension
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Unreviewed
21 Active
20 Inactive
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please don't store any instance of objects in a property in the default class you are exporting (line 14 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You can clean up on window close request if you don't want to attach it to `window`: ```js window.connect('close-request', () => { // clean up here }); ```