Review "Moon Phases" version 1 - GNOME Shell Extensions

Review of "Moon Phases" version 1

Details Page Preview

Moon Phases

by Xynium

Moon and sun data

Extension Homepage: https://github.com/xynium/moonphases

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
6	Active
5	Active
4	Rejected
3	Inactive
2	Rejected
1	Rejected

Previous Reviews on this Version

corvettecole rejected August 25, 2022

you must destroy all objects in disable(). Currently, your settings object is not destroyed. Please review the following: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#basics

Xynium posted a review August 26, 2022

Hi, i will change to : function disable() { Mainloop.source_remove(timeout); delete(settings); delete(label); myPopup.destroy(); } and send you another zip file in few hour JP