Review of "Moon Phases" version 2

Details Page Preview

Moon and sun data

Extension Homepage
https://github.com/xynium/moonphases

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove all .po files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Also do this in disable: ```js myPopup = null; ``` 5. Don't do lines 21-24 extension.js and lines 10-13 prefs.js for gettext. Do this instead: ```js const Gettext = imports.gettext.domain('moonphases'); const _ = Gettext.gettext; ``` 6. Remove lines 25-38 prefs.js. Use `ExtensionUtils.getSettings()` instead: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/4a0cfbc5d6711cfce592d79cc62b89de8b86cb08/js/misc/extensionUtils.js#L211 7. You cannot import prefs.js inside extension.js file (line 15 extension.js). If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Xynium posted a review
Hi, Updated every point, but point 5 does not functioning. i have changed to : (Begining of calc.js that has most of the translation) const Me = imports.misc.extensionUtils.getCurrentExtension(); const Gettext = imports.gettext.domain('moonphases'); /* old const Gettext = imports.gettext; Gettext.bindtextdomain("moonphases", Me.dir.get_child("locale").get_path()); Gettext.textdomain("moonphases"); */ const _ = Gettext.gettext; var iAA,iMM,iJJ; But do not translate Other problem got a message : Usage of object.actor is deprecated for St_BoxLayout Back to you when i solve that JP
JustPerfection posted a review
Did you do this inside init? ```js ExtensionUtils.initTranslations('moonphases'); ``` For `actor`, you don't need to use `.actor`.
Xynium posted a review
ok should use 'moonphases' in ExtensionUtils.initTranslations('moonphases'); and not Me.metadata.uuid for actor i use this.mainBox.add_actor(customButtonBox); seem to be ok no warning i am not easy on javascript, furthermore many tuto and other extension are not up to date. I use many part of code from other extension. I send you an other zip