Review of "Toggle nemo" version 5

Details Page Preview

Shows or hides the last nemo window file manager (Fork of Toogle nautilus extension). Press Super+E This extension requires the Nemo file manager (tested with Nemo 2.4.4) http://www.webupd8.org/2014/04/install-nemo-220-with-unity-patches-in.html Press Super+E is a toogle mode for nemo. Press Super+F1 run a new window instance for the "Documents" folder Press Super+F2 run a new window instance for the "Downloads" folder Press Super+F3 run a new window instance for the "Music" folder Press Super+F4 run a new window instance for the "Pictures" folder Press Super+F5 run a new window instance for the "Videos" folder If nemo does not start please try this: gsettings set org.gnome.desktop.background show-desktop-icons true gsettings set org.nemo.desktop show-desktop-icons false


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Rejected
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove all .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 3. Lang is a deprecated module. Please remove it for the next version (Supported on 3.36 and higher): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 4. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove utils.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js Supported on 3.34 and higher. 5. Did you test the prefs in 40, 41 and 42? I see you used `frame.show_all();` which gtk 3 related. Port Guide for GNOME Shell 40: https://gjs.guide/extensions/upgrading/gnome-shell-40.html#metadata-json 6. You cannot create objects in global scope (line 11, 29 extension.js, line 6 prefs.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 7. Multi versioning is supported here, so you can remove the 3.x versions if you want. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions