Review "Notification Filter" version 1

Review of "Notification Filter" version 1

Details Page Preview

Notification Filter

by AsyncLink

Filter out notifications by their text content to block them from appearing.

Extension Homepage: https://github.com/spybug/NotifyFilter-GnomeExtension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
8	Active
7	Active
6	Rejected
5	Active
4	Rejected
3	Inactive
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected October 5, 2022

1. You cannot create objects in global scope (line 8,22 prefs.js) Move them to `buildPrefsWidget()` and make them local not global. 2. Move line 19 to `buildPrefsWidget()`. 3. Move line 10 to enable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization and null that out in disable. 4. null out `filterSettings` in disable. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions