Review of "Notification Filter" version 6

Details Page Preview

Filter out notifications by their text content to block them from appearing.

Extension Homepage
https://github.com/spybug/NotifyFilter-GnomeExtension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `lookupByURL()` is a bad practice. You can use `this.getSettings()` instead (line 21 `extension.js`). 2. Dont' hold any instances after window close (line 10-15 `prefs.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) I recommend to make them local to `fillPreferencesWindow()` and pass them to the other methods and functions.