Review "Nano Lights" version 1 - GNOME Shell Extensions

Review of "Nano Lights" version 1

Details Page Preview

Nano Lights

This extension controls Nanoleaf shapes and possibly others Nanoleaf devices on your local (wifi) network. If you are experiencing an error on the upgrade, please log out and log in again.

Extension Homepage: https://github.com/vchlum/nano-lights

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected November 12, 2022

1. Please null out `nanoLightsMenu` in disable. 2. You cannot create objects in global scope which is the same as init (line 52 nanomenu.js, line 58 utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. Timeout should be removed on destroy or disable (line 374, 1338 and 1673 nanomenu.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. Add XML file in schemas folder: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas