Review of "Nano Lights" version 5

Details Page Preview

This extension controls Nanoleaf shapes and possibly others Nanoleaf devices on your local (wifi) network. If you are experiencing an error on the upgrade, please log out and log in again.

Extension Homepage
https://github.com/vchlum/nano-lights

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What's the reason for import inside that function (line 51 prefs.js)?
chlumskyvaclav posted a review
In prefspage.js, I use gresource as template. See the use: "Template: 'resource:///org/gnome/Shell/Extensions/nano-lights...'" in prefspage.js on few places. So, I need to call: 'Gio.resources_register(resource);' in prefs.js before importing prefspage.js in order to have the templates working. That is reason for the dynamic import.
chlumskyvaclav posted a review
In prefspage.js, I use gresource as template. See the use: "Template: 'resource:///org/gnome/Shell/Extensions/nano-lights...'" in prefspage.js on few places. So, I need to call: 'Gio.resources_register(resource);' in prefs.js before importing prefspage.js in order to have the templates working. That is reason for the dynamic import.
JustPerfection active