Review of "Sound Visualizer" version 3

Details Page Preview

A Real Time Sound Visualizer Based On Gstreamer

Extension Homepage
https://gitlab.com/raihan2000/visualizer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
Ok but `settings` in prefs.js still has global issue. The reason we don't want to that is garbage collection. It won't get garbage collected after window close. To fix that move line 12 (prefs.js) to `fillPreferencesWindow()` and `buildPrefsWidget()`. Also make `settings` local. then you can use dependency injection for `prefsWidget` and `PrefsWindow`. Also you can pass that as an argument to the functions they need it.