Review of "Sound Visualizer" version 5

Details Page Preview

A Real Time Sound Visualizer Based On Gstreamer

Extension Homepage
https://gitlab.com/raihan2000/visualizer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

raihan2000 posted a review
Sorry for delay to update my repo, now https://gitlab.com/raihan2000/visualizer is uptodate with v5, Is there any issue you have found? just let me know Thanks in Advance
JustPerfection rejected
1. The timeouts you are creating in `visual.js` can be created multiple times without removing the old ones. Please remove the timeout before creating a new one. 2. `lookupByURL()` is a bad practice: - line 11, 109 `prefs.js` - line 35 `visual.js` You can send `this` from the entry point to the class needing it (dependency injection). 3. I recommend to use `destroy()` instead of `onDestroy()`. At the end of that function you can do `super.destroy()`.