Review of "Home Assistant Extension" version 12

Details Page Preview

A simple gnome shell extension for Home Assistant. Check the README on github for additional help! Main points: - You need to provide the url of your hass, a long live access token obtained from your profile page (on your hass web instance) and the entity ids of the entities you want to have as togglable. - In order to add some local temperature/humidity sensor, you may also provide a temperature and/or a humidity entity id (which should match the corresponding ids of your hass instance).

Extension Homepage
https://github.com/geoph9/hass-gshell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
25 Active
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Rejected
12 Rejected
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Inactive
3 Active
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 4 utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. As I mentioned in version 6 review, please remove Lang: https://extensions.gnome.org/review/28000 3. Also remove .po and .pot files as I mentioned in version 11 review: https://extensions.gnome.org/review/33427
geoph posted a review
Thanks for the feedback! I am actually aware of the first issue, but I couldn't think of a way to solve it. Do you maybe have any hints? I don't think the link you attached is very relevant since TOKEN_SCHEMA needs to be initialized only once and it's only used in utils.js (for authentication) and prefs.js (where the token is first submitted). So how could TOKEN_SCHEMA be initialized once in utils.js and then accessed by prefs.js? About the Lang bindings removal, it took me a bit long but I finally did it and will upload the changes in the next version.
JustPerfection posted a review
How about: ```js let tokenSchema; function getTokenSchema() { if (!tokenSchema) { tokenSchema = Secret.Schema.new( "org.gnome.hass-data.Password", Secret.SchemaFlags.NONE, { "token_string": Secret.SchemaAttributeType.STRING, } ); } return tokenSchema; } ```
geoph posted a review
Right, thank you for devoting time to this! I'll upload the revised version shortly.