Review of "Home Assistant Extension" version 13

Details Page Preview

A simple gnome shell extension for Home Assistant. Check the README on github for additional help! Main points: - You need to provide the url of your hass, a long live access token obtained from your profile page (on your hass web instance) and the entity ids of the entities you want to have as togglable. - In order to add some local temperature/humidity sensor, you may also provide a temperature and/or a humidity entity id (which should match the corresponding ids of your hass instance).

Extension Homepage
https://github.com/geoph9/hass-gshell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
25 Active
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Rejected
12 Rejected
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Inactive
3 Active
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
Thanks! but you still creating objects in global scope (line 30, 34 and 41 prefs.js). Create them as local in `buildPrefsWidget()` and pass them as argument or dependency injection to the functions and classes needing them. We are against that because those global variables won't get garbage collected after window close.
geoph posted a review
I was under the impression that e.g. `notebook` would get destroyed right after calling `buildPrefsWidget()` and the GUI would collapse. But, apparently, it remains as a structure in the Gtk.Grid instance that uses it (which makes sense). I haven't worked on pure software development for quite some time, and I guess I need to refresh my skills. I appreciate the help and explanations! Hopefully my next release will be fine.