GNOME Shell Extensions

Review of "App Icons Taskbar" version 15

Details Page Preview

App Icons Taskbar

by andrew.zaech

A simple app icon taskbar. Show running apps and favorites on the main panel.

Extension Homepage
https://gitlab.com/AndrewZaech/aztaskbar
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection waiting for author
1. What's the reason for giving the timeout to the owner (line 68 windowPreview.js)? It makes it hard to review. 2. Why not extending `Signals.EventEmitter` instead of `addSignalMethods` (line 113 notificationsMonitor.js)? https://gjs.guide/extensions/upgrading/gnome-shell-43.html#signals
JustPerfection waiting for author
Missed the shell version for #2 (not supported on 42).
andrew_z posted a review
1. What's the reason for giving the timeout to the owner (line 68 windowPreview.js)? It makes it hard to review. Sorry about that. It's just how I decided to remove the timeout when the owner is destroyed. It would make more sense to handle it from within the WindowPreviewMenuManager class
JustPerfection active
Approved! You can keep it like that but that should be consider anti pattern :p