Review of "App Icons Taskbar" version 19

Details Page Preview

A simple app icon taskbar. Show running apps and favorites on the main panel.

Extension Homepage
https://gitlab.com/AndrewZaech/aztaskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection waiting for author
IMO getting extension instance with `lookupByURL()` is a bad practice. Especially over doing it in so many modules. I can approve your extension like this if you want. I guess as soon as someone sees this approach we will get flooded with extensions doing that. While I'm against global approach. Maybe attaching it to the global would be much easier. The best approach is dependency injection though. For example, line 963 prefs.js can be: ```js const aboutPage = new AboutPage(settings); ```
andrew_z posted a review
You make a good point. It did make for an easier approach to porting the previous code base to the ESM and GNOME 45 changes. I have no objections to reworking it if this is a practice you don't want to encourage.
JustPerfection waiting for author
I'll change the status so it doesn't get stuck in the review queue. Please change it if that's possible. Thanks!
andrew_z posted a review
A few of the classes that are using lookupByUrl() would need to have the base extension class passed down through multiple other classes just to have access to it, which seems inconvenient. It is used twice in https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/main/extensions/window-list/extension.js for similar purposes to how I am using it. Also I took a look at dash to dock's gnome 45 port. They use a custom "DockManager" class with static methods that they use to get the extension , extension settings, , etc. "DockManager.settings" is used extensively throughout the extension instead of dependency injection. Using lookupByUrl() seems more practical to me in certain situations compared to dependency injection.
JustPerfection active
Ok. Use dependency injection only when it's convenient.