GNOME Shell Extensions

Review of "Proxy Switcher" version 7

Details Page Preview

Proxy Switcher

by flannable

Switches between the system proxy settings profiles defined in Network Settings.

Extension Homepage
https://github.com/tomflannaghan/proxy-switcher
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Rejected
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active
OK, though two comments: - bindtextdomain() will just silently fail if the directory does not exists, so you don't have to test for its existence first - why do you implement your own radio items with the dot at the end rather than just using setOrnament() like other menus do? (see the keyboard status menu for an example)