Review of "System Monitor" version 27

Details Page Preview

Display resource usage. Linux distribution specific installation instructions can be found in the wiki at https://github.com/elvetemedve/gnome-shell-extension-system-monitor/wiki/Installation. Please report bugs here: https://github.com/elvetemedve/gnome-shell-extension-system-monitor/issues

Extension Homepage
https://github.com/elvetemedve/gnome-shell-extension-system-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
38 Active
37 Rejected
36 Active
35 Active
34 Active
33 Active
32 Rejected
31 Active
30 Rejected
29 Rejected
28 Active
27 Rejected
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Inactive
15 Rejected
14 Active
13 Active
12 Active
11 Inactive
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
Did you test it on 3.x versions? I don't think properties like line 9 and 64 (helpers/async.js) would work on 3.x versions. You did that in other files too.
elvetemedve posted a review
No, I haven't. Thanks for pointing that out. The problem is that it would require a lot of effort to test all Gnome versions listed in metadata.json. I'm aware of the idea to get support to run code in various Gnome environments by the Gnome Builder, but that still has not been implemented yet. See https://gitlab.gnome.org/GNOME/gnome-builder/-/issues/1484 Is there any option to check it other than installing a full OS for each Gnome version manually? Ideally an automated smoke test could be written for testing this out. If manual testing is the only option now, then I would rather change the JS syntax to the old format.
JustPerfection rejected
I'm going to reject this since that shouldn't work on 3.x versions but you have these options: 1. Use VM to test it out before sending them to ego. 2. Use your own API with version checking like what I do with my own extension. That's not related to this issue though. It will only apply to different monkey patching for different GNOME Shells. 3. Drop old versions and only use current GNOME Shell version in the metadata. ego supports multi versioning so the old versions will be only available for users with old GNOME Shells.