Review of "System Monitor" version 29

Details Page Preview

Display resource usage. Linux distribution specific installation instructions can be found in the wiki at https://github.com/elvetemedve/gnome-shell-extension-system-monitor/wiki/Installation. Please report bugs here: https://github.com/elvetemedve/gnome-shell-extension-system-monitor/issues

Extension Homepage
https://github.com/elvetemedve/gnome-shell-extension-system-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
34 Active
33 Active
32 Rejected
31 Active
30 Rejected
29 Rejected
28 Active
27 Rejected
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Inactive
15 Rejected
14 Active
13 Active
12 Active
11 Inactive
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
1. `lookupByURL()` is a bad practice: - line 68 `factory.js` - line 257 `util.js` - line 17 `view.js` You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 2. Not really needed to create multiple instance of settings (line 55 `extension.js`). 3. You can do `this.stop()` in `Timer.destroy()` (line 44 `extension.js`). so you only need to call `destroy()`. after that you can remove line 60 `extension.js`. Wanna fix and send it again?
elvetemedve posted a review
Thanks for the feedback. Yes, I will update the code and submit again.
elvetemedve auto- rejected
Auto-rejected because of new version 30 was uploaded