1. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 2. Bad schema id, path and xml file name: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas 3. Multi versioning is supported here, so you can remove 3.x versions and use new syntax and tools. 4. 3.x is using soup version 2 not 3 (line 23 convenience.js). You cannot change the version there since it has been already loaded. 5. After removing 3.x you can use `initTranslations()` and `getSettings()` from `ExtensionUtils` instead of creating your own custom functions (line 44-74 convenience.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 7. You can use `onDestroy` instead of `remove_events` (line 241 extension.js). It will be called when you call `destroy()`. 8. Also null out `freedesktop` in disable. 9. What's the reason for creating app for prefs? The port guide is here if you need it: https://gjs.guide/extensions/upgrading/gnome-shell-40.html https://gjs.guide/extensions/upgrading/gnome-shell-42.html https://gjs.guide/extensions/upgrading/gnome-shell-43.html https://gjs.guide/extensions/upgrading/gnome-shell-44.html We also offer our help if you need any help with the port guide. (Matrix channel link at the end of the reply) 10. You should clean up every global variables on disable (like `icons`, line 47 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 11. Don't use cryptic names for parameters (line 186, 225). Code should be readable for reviewers: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#code-must-not-be-obfuscated 12. Use `ExtensionUtils.openPrefs()` instead of spawn command (line 543 extension.js) 13. If you really want to support 3.x versions alongside 4x versions, you can create multiple prefs interface and load them on prefs.js base on the current version: - `prefsGtk3.js` (3.x) - `prefsGtk4.js` (40-44) - `prefsAdw.js` (42-44 is GTK4 + Adw. GTK4 only ui also works) If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

thanks