Review of "AppKeys" version 4

Details Page Preview

Adds Super+NUM hotkeys for activating application based on Dash. Like in Ubuntu, the Unity hotkeys. Works with keypad and numbers. So pressing Super+1 has the same affect as clicking on the first app in dash, Super+2 the same as clicking on the second, etc. To start a new instance of the respective application use Shift+Super+NUM. Use configuration to disable any option you don't like.

Extension Homepage
https://github.com/franziskuskiefer/app-keys-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

fmuellner rejected
Some comments: - Main.wm.setCustomKeybindingHandler() is only available since 3.8, so all previous version you claim to support won't work - you should use Main.wm.addKeybinding() instead of global.display.add_keybinding() + Main.wm.setCustomKeybindingHandler() - for symmetry, I recommend using Main.wm.removedKeybinding as well - in prefs, you don't update the switch when the setting changes; something like let settingSwitch = new Gtk.Switch(); settings.bind(conf, settingSwitch, 'active', Gio.SettingsBindFlags.DEFAULT); should do the trick - again in prefs, the vbox really could use some spacing between rows All but the first item are nitpicks that would be nice to fix, but not necessary for approval; however you should either update the metadata, or add a compatibility wrapper like: _addKeybinding(name, handler) { if (Main.wm.addKeybinding) Main.wm.addKeybinding(name, this.settings, Meta.KeyBindingFlags.NONE, Shell.KeyBindingMode.NORMAL, handler); else global.display.add_keybinding(name, this.settings, Meta.KeyBindingFlags.NONE, handler); }