Review of "Magfix" version 1

Details Page Preview

Magnifier cursor shift fix.

Extension Homepage
https://github.com/andrejgricenko/magfix

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Why eval (line 23 extension.js)?
Ghost posted a review
I need to replace the createZoomRegion magnifier function with another version of this function. The magnifier itself does not use this function, but perhaps it is called somewhere else. I don't know of any other way than eval to do this.
JustPerfection rejected
That's [this method](https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/287f87252cd3c414164c99a953410fecd3bfc968/js/ui/magnifier.js#L285). You can do that with prototype: ```js const Magnifie = imports.ui.magnifie; let MagnifierProto = Magnifie.Magnifier.prototype; let createZoomRegionOriginal = MagnifierProto.createZoomRegion; function enable() { MagnifierProto.createZoomRegion = () => { // new function }; } function disable() { // revert back to orignal MagnifierProto.createZoomRegion = createZoomRegionOriginal; } ``` If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions