Review "Quick Settings Audio Panel" version 16

Review of "Quick Settings Audio Panel" version 16

Details Page Preview

Quick Settings Audio Panel

by Rayzeq

Create a new panel containing volumes and media control in the quick settings

Extension Homepage: https://github.com/Rayzeq/quick-settings-audio-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
74	Active
73	Active
72	Rejected
71	Active
70	Rejected
69	Active
68	Active
67	Active
66	Rejected
65	Rejected
64	Active
63	Active
62	Active
61	Active
60	Active
59	Rejected
58	Active
57	Active
56	Active
55	Rejected
54	Active
53	Active
52	Active
51	Active
50	Rejected
49	Active
48	Active
47	Active
46	Active
45	Active
44	Active
43	Active
42	Active
41	Active
40	Rejected
39	Rejected
38	Active
37	Active
36	Active
35	Active
34	Active
33	Active
32	Active
31	Active
30	Rejected
29	Rejected
28	Rejected
27	Rejected
26	Active
25	Rejected
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Rejected
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 6, 2023

You cannot create instances in global scope (line 867-868 libs/libpanel/main.js) and don't attach anything to `global`. That is `Shell.Global` and attaching 3rd party libraries to it, doesn't fit the purpose. You have two options: 1. Don't make it a library that other extensions can use it. We want extensions to clean up on disable. Create the instance on enable and clean up on disable. 2. Make another extension that can act like API (not a library). In that case you just need to check if that extension is enabled and use it as an API. The API extension can attach the instance to something like `Main.panel.libpanel`, so other extensions can use it.