Review "Quick Settings Audio Panel" version 65

Review of "Quick Settings Audio Panel" version 65

Details Page Preview

Quick Settings Audio Panel

by Rayzeq

Create a new panel containing volumes and media control in the quick settings

Extension Homepage: https://github.com/Rayzeq/quick-settings-audio-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
100	Active
99	Active
98	Active
97	Active
96	Rejected
95	Active
94	Active
93	Active
92	Active
91	Active
90	Active
89	Active
88	Active
87	Active
86	Active
85	Active
84	Active
83	Active
82	Active
81	Active
80	Active
79	Rejected
78	Rejected
77	Active
76	Active
75	Rejected
74	Active
73	Active
72	Rejected
71	Active
70	Rejected
69	Active
68	Active
67	Active
66	Rejected
65	Rejected
64	Active
63	Active
62	Active
61	Active
60	Active
59	Rejected
58	Active
57	Active
56	Active
55	Rejected
54	Active
53	Active
52	Active
51	Active
50	Rejected
49	Active
48	Active
47	Active
46	Active
45	Active
44	Active
43	Active
42	Active
41	Active
40	Rejected
39	Rejected
38	Active
37	Active
36	Active
35	Active
34	Active
33	Active
32	Active
31	Active
30	Rejected
29	Rejected
28	Rejected
27	Rejected
26	Active
25	Rejected
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Rejected
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected October 30, 2024

Before line 151 and 153 `libs/widgets.js` you should do: ```js if (this._setup_timeout) { clearTimeout(this._setup_timeout); } ```

Rayzeq posted a review October 30, 2024

Whoops, I published version 66 without seeing this. Although before line 151 and 153, we're inside the call stack generated by the current `this._setup_timeout`, so it won't have any effect.

JustPerfection posted a review October 30, 2024

You should remove the timeout before creating the new one since they are storing the id in the same property name.