GNOME Shell Extensions

Review of "Overview All Windows" version 2

Details Page Preview

Overview All Windows

by amiller27

Shows windows from all workspaces in the overview.

Extension Homepage
http://github.com/amiller27/OverviewAllWindows
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

Meng Zhuo waiting for author
PLEASE disconnect this._overviewHiddenId in disable function.
amiller27 posted a review
_overviewHiddenId is disconnected in Workspace.Workspace._onDestroy. It is the same listener that is used by the default workspace implementation, so I assume it is fine for the default workspace implementation to disconnect it when it sees fit.
Meng Zhuo active
Hmm...clever Line 1762 >>> if (this._overviewHiddenId) { >>> Main.overview.disconnect(this._overviewHiddenId); >>> this._overviewHiddenId = 0; >>> }