Review of "Activities Workspace Name" version 7

Details Page Preview

Replace Activities Text with Current Workspace Name

Extension Homepage
https://github.com/ahmafi/gnome-activities-workspace-name

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
Thanks! Inside the timeout callback, you should also null out (or = 0) the timeout source id to avoid remove warnings. For example, here I modified [the example](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) for source remove: ```js function enable() { sourceId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 5, () => { console.log('Source triggered'); sourceId = null; // <------- should be null out here too return GLib.SOURCE_REMOVE; }); } function disable() { if (sourceId) { GLib.Source.remove(sourceId); sourceId = null; } } ```