GNOME Shell Extensions

Review of "Activities Workspace Name" version 8

Details Page Preview

Activities Workspace Name

by ahmafi

Replace Activities Text with Current Workspace Name

Extension Homepage
https://github.com/ahmafi/gnome-activities-workspace-name
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
Ok, you also have another timeout callback (line 163 `extension.js`).
Amir posted a review
Yes, that one removes sets the timeout to null in the called function.
JustPerfection posted a review
That is a bad practice though. The call back in line 163 should be: ```js this._xdndToggleOverview(); this._xdndTimeOut = 0; return GLib.SOURCE_REMOVE; ``` It will be improve the readability and it will be easier to review.