Review of "Search Light" version 13

Details Page Preview

Take the apps search out of overview.

Extension Homepage
https://github.com/icedman/search-light

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Use `const` instead of `var` (line 7 keybinding.js). 2. You cannot create instance of objects in global scope (line 7 preferences/keys.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. Where do you use: - `effects/color_effect.glsl` - `effects/color_effect.js` - `utils.js` 4. Null out every member of the default class you are exporting in `extension.js`. For example: ```js this._hiTimer = null; this._loTimer = null; this._style = null; // ... ``` The ideal would be to move all of those methods to another class though, and just create an instance of that class inside enable and null that out in disable. so, only that instance needed to get null out on disable.