Review of "Search Light" version 26

Details Page Preview

Take the apps search out of overview.

Extension Homepage
https://github.com/icedman/search-light

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. As mentioned before, you should do this in disable: ```js this._providers = []; this._unitConversion = null; this._currencyConversion = null; ``` 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logg 3. Add to the description that this extension is using exchangerate-api.com for currency plugin. 4. Where do you use `plugins/units/tests/conv.js`? 5. You cannot create instance of objects in global scope (line 12 `plugins/units/units.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 6. Any code copied from other extensions or libraries need to include the copyright.