Review of "Search Light" version 40

Details Page Preview

Take the apps search out of overview.

Extension Homepage
https://github.com/icedman/search-light

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
1. What's the reason for the check on line 47-53 `extension.js`? `GioUnix` is already one of the dependencies of GNOME Shell. 2. What line 589-606 `extension.js` is trying to do? Using Blur my Shell extension's function? Isn't it better to ask the dev for giving a css class name so any other extensions can use that without going through the extension's code?
icedman posted a review
1. I used Gio.DesktopAppInfo but journalctl prints warning to update my code using GioUnix.DesktopAppInfo instead; 2. Yes - using Blur-my-Shell's function. It blurs Dash-to-Dock. I already ask the developer before to support Search Light and Dash2Dock Animated. But it is perhaps a bit much to ask. In the meantime my extensions just pretend to be a "Dash-to-Dock" - by creating "proxy" widgets with appropriate classes so that blurring is applied. Search Light needs to hook (instead of waiting to be detected by Blur-my-Shell) as it popups on a key shortcut and the background size is dynamic as the user types to search. try_blur function has been there since Gnome 46, I'm mostly assured it will be there in the near future.
JustPerfection waiting for author
You shouldn't need that check. IIRC, you can do `GioUnix.DesktopAppInfo` in 45+. Wanna remove and send it again?
icedman posted a review
Yes. Will resent later. Thanks
icedman auto- rejected
Auto-rejected because of new version 41 was uploaded