Review of "Debian Linux Updates Indicator" version 2

Details Page Preview

Updates indicator for Debian Linux based distributions. Check for updates and shows also the following packages status (as in Synaptic): ⚫ Available updates. ⚫ New packages in repository. ⚫ Local/Obsolete packages. ⚫ Residual config files. ⚫ Autoremovable packages.

Extension Homepage
https://gitlab.gnome.org/glerro/gnome-shell-extension-debian-updates-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.2.3 (17) Active
2.4.2 (16) Active
2.4.1 (15) Active
1.2.2 (14) Active
2.4.0 (13) Active
2.3.0 (12) Active
1.2.1 (11) Active
2.2.2 (10) Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Shouldn't be saved in global scope (line 33 ignoreListBox.js). Pass it to the constructor of the classes needed settings (dependency injection). 2. You cannot create instances in global scope which is the same as init (line 56 indicator.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. Move `settings` to `buildPrefsWidget()` and `fillPreferencesWindow()` as local and pass it as dependency injection (line 650 prefs.js). 4. Don't use the same timeout id (line 198 and 217 updateManager.js). 5. Timeout should be removed on destroy (line 323 updateManager.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 6. Use cancelabe so you can cancel the process on disable (line 479 updateManager.js): https://gjs.guide/guides/gio/subprocesses.html#complete-examples
glerro posted a review
Can you chack if this commit (https://gitlab.gnome.org/glerro/gnome-shell-extension-debian-updates-indicator/-/commit/b503ca0c5a5eb8ca6b37529b56d33259dc02058e) resolve the point 6? The two previous commit resolve the other points. Thanks!
glerro posted a review
Can you chack if this commit (https://gitlab.gnome.org/glerro/gnome-shell-extension-debian-updates-indicator/-/commit/b503ca0c5a5eb8ca6b37529b56d33259dc02058e) resolve the point 6? The two previous commit resolve the other points. Thanks!
JustPerfection posted a review
It's ok just use `this._cancellable.cancel()` before starting using it, because you are using that instance in multiple methods.
glerro posted a review
You intend when i create the cancellabile or before every proc.init. Before every proc.init Is not possibile because sub process are lauched sequentially and one of this launch another subprocess. gjs-docs.gnome.org say that "One Gio.Cancellable can be used in multiple consecutive or in multiple concurrent operation".
JustPerfection posted a review
It's ok. send it like that. missed the stack.