Review of "Hotel Manager" version 21

Details Page Preview

Hotel Manager allows to start and stop the Hotel daemon and your development servers via a menu in the status area.

Extension Homepage
https://github.com/hardpixel/hotel-manager

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
21 Rejected
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please remove the timeout on destroy (line 61 widgets.js). Also call that destroy on each item you are creating in extension.js
JustPerfection posted a review
Please use less generic class name for the default class you are exporting (for stack trace).
hardpixel posted a review
There is no destroy in line 61 widgets.js. It is a restart button that restarts the hotel server, it needs a timeout t make sure the server has stopped to restart it again.
JustPerfection posted a review
There is a timeout there that needs to be removed on destroy: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
hardpixel posted a review
The function returns false aka GLib.SOURCE_REMOVE. I don't understand what you want me to do. I will not submit a new version. If you don't want to pass it then so be it.
JustPerfection posted a review
As mentioned in the review guidelines: > You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE.