Review of "Dash to Plank" version 16

Details Page Preview

GNOME Shell integration for Plank, the simplest dock on the planet. To use this extension, you must have Plank installed on your system. This extension depends on Plank. To install it: - Debian/Ubuntu: apt install plank - Fedora/RHEL: dnf install plank - Arch: pacman -S plank ** This extension does NOT WORK on WAYLAND.

Extension Homepage
https://github.com/hardpixel/dash-to-plank

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't use the same property name for the timeout (line 132 and 145 extension.js). 2. Please use less generic class name for the default class you are exporting (for stack trace).
hardpixel posted a review
The same handler id is used because the only one of the functions _onInitialized or _onInitialize runs. THEY NEVER RUN BOTH. CHECK LINE 167. I will not submit a new version. If this does not pass I don't care.
JustPerfection posted a review
As we discussed in the Matrix room, having the same timeout is hard to follow for reviewers.