Review of "Phi: Pi-hole Indicator" version 1

Details Page Preview

Quickly access your beloved Pi-hole from GNOME Shell. Phi provides the following features: - Monitor single or multiple Pi-hole instances, - Enable/disable blocking, - Display status and main statistics, - Show version information of Pi-hole, and notify when there is an update. You can also configure Phi to look for Pi-hole only in a certain network. This might be useful if your computer connects to school, work or public Wi-Fi.

Extension Homepage
https://github.com/ziyagenc/phi

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.7 (14) Active
1.6 (13) Active
1.5 (12) Active
1.4 (11) Inactive
1.3 (10) Active
1.3 (9) Rejected
8 Inactive
7 Inactive
6 Active
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Move line 17-18 (dbus.js) to `_getNetworkIdProxyAsync()` and `_getNetworkProxyAsync()`, because global scope is the same as init: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Please use `console.*` instead of `log()` (we have that since GNOME Shell 42): https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging 3. To make it easier for porting to 45, you can use settings as dependency injection for `PiholeIndicator` (line 13 indicator.js).
Ziya Genç posted a review
Thanks for the feedback. 1. & 2. are done, and submitting the new version right now. 3. GNOME 45 port currently injects uuid for another requirement, and obtains settings from uuid. Thanks for the advise, I will use it (inject both uuid and settings).