Review of "Phi: Pi-hole Indicator" version 4

Details Page Preview

Quickly access your beloved Pi-hole from GNOME Shell. Phi provides the following features: - Monitor single or multiple Pi-hole instances, - Enable/disable blocking, - Display status and main statistics, - Show version information of Pi-hole, and notify when there is an update. You can also configure Phi to look for Pi-hole only in a certain network. This might be useful if your computer connects to school, work or public Wi-Fi.

Extension Homepage
https://github.com/ziyagenc/phi

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.7 (14) Active
1.6 (13) Active
1.5 (12) Active
1.4 (11) Inactive
1.3 (10) Active
1.3 (9) Rejected
8 Inactive
7 Inactive
6 Active
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
`lookupByUUID` shouldn't be used when provided by the entry point. Do this instead: ```js this._indicator = new PiholeIndicator(this); ``` then: ```js class PiholeIndicator extends GObject.Object { constructor(me) { ``` That's the easy fix but I suggest to create gsettings only once in the entry point to avoid creating multiple instances in different modules. to do that, you can do this instead: ```js this._indicator = new PiholeIndicator(this, this.getSettings()); ```
Ziya Genç posted a review
Thanks, updated accordingly & resubmitted.