Review of "Custom Accent Colors" version 7

Details Page Preview

A GNOME Shell Extension that provides 7 Custom Accent Colors for versions 43-46. The selected Accent Color can be applied to GTK4/GTK3 apps and the Gnome Shell.

Extension Homepage
https://github.com/demetrisk03/custom-accent-colors

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
Thanks!
JustPerfection rejected
1. Extensions cannot use `run_dispose()` (line extension.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose 2. Please use `console.error(e)` instead of `log(e)`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging
demiskp posted a review
so if I remove the line: `this.settings?.run_dispose();` and replace every: `log(e);` with: `console.error(e);` then the extension will be fine?
JustPerfection posted a review
Yes!