Review "Fedora Linux Update Indicator" version 1

Review of "Fedora Linux Update Indicator" version 1

Details Page Preview

Fedora Linux Update Indicator

GNOME Shell update indicator for Fedora Linux. This is based on Arch Linux Updates Indicator by Raphaël Rochet. This extension is not affiliated, funded, or in any way associated with Fedora brand and Red Hat Software.

Extension Homepage: https://github.com/purejava/fedora-update

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
25	Active
24	Inactive
23	Inactive
22	Inactive
21	Inactive
20	Inactive
19	Rejected
18	Rejected
17	Inactive
16	Inactive
15	Inactive
14	Rejected
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Rejected
4	Active
3	Rejected
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected October 14, 2023

1. Please move line 32 prefs.js to `fillPreferencesWindow`. You can attach it to the window to avoid garbage collecting before window close. 2. Do that on enable (line 74 extension.js). and delete that on disable (not nulling that out). 3. It's better to move line 581-585 to `FedoraUpdateIndicator`. 4. You can add `gettext-domain` to metadata.json to make it easier for 45 port: https://gjs.guide/extensions/overview/anatomy.html#metadata-json-required 5. You should clean up `UPDATES_LIST` in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects