Review of "Fedora Linux Update Indicator" version 6

Details Page Preview

GNOME Shell update indicator for Fedora Linux. This is based on Arch Linux Updates Indicator by Raphaƫl Rochet. This extension is not affiliated, funded, or in any way associated with Fedora brand and Red Hat Software.

Extension Homepage
https://github.com/purejava/fedora-update

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
Thanks!
purejava posted a review
Hi, this is a minor update. I fixed a feature with v7. Here is the diff to v6. Thanks. commit ac79be5544b2bfa503fb58c4c4a4625d21f7f990 Author: Ralph Plawetzki <ralph@purejava.org> Date: Sat Oct 28 14:35:28 2023 +0200 Submit version 7 Assumed feature : Show package info diff --git a/extension.js b/extension.js index e5fc7d3..1bacf4e 100644 --- a/extension.js +++ b/extension.js @@ -482,19 +482,19 @@ class FedoraUpdateIndicator extends Button { } _packageInfo(item) { - let proc = this.launcher.spawnv(['pacman', '-Si', item]); + let proc = this.launcher.spawnv(['dnf', 'info', item]); proc.communicate_utf8_async(null, null, (proc, res) => { - let repo = "REPO"; - let arch = "ARCH"; + let name = "NAME"; + let rootPackage = "PACKAGE"; let [,stdout,] = proc.communicate_utf8_finish(res); if (proc.get_successful()) { - let m = stdout.match(/^Repository\s+:\s+(\w+).*?^Architecture\s+:\s+(\w+)/ms); + let m = stdout.match(/^Name\s+:\s+(\w+(-\w+)*)*.*?^Source\s+:\s+((\w+)(-\w+)?)(-\d)/ms); if (m !== null) { - repo = m[1]; - arch = m[2]; + name = m[1]; // should be same as item + rootPackage = m[3]; } } - let command = PACKAGE_INFO_CMD.format(item, repo, arch); + let command = PACKAGE_INFO_CMD.format(rootPackage, item); Util.spawnCommandLine(command); }); } diff --git a/metadata.json b/metadata.json index 4878994..d0785f3 100644 --- a/metadata.json +++ b/metadata.json @@ -6,5 +6,5 @@ "uuid": "update-extension@purejava.org", "gettext-domain": "update-extension@purejava.org", "settings-schema": "org.gnome.shell.extensions.fedora-update", - "version": 6 + "version": 7 } diff --git a/schemas/gschemas.compiled b/schemas/gschemas.compiled index 2e7ce8a..6845240 100644 Binary files a/schemas/gschemas.compiled and b/schemas/gschemas.compiled differ diff --git a/schemas/org.gnome.shell.extensions.fedora-update.gschema.xml b/schemas/org.gnome.shell.extensions.fedora-update.gschema.xml index 6e5ca80..4c27090 100644 --- a/schemas/org.gnome.shell.extensions.fedora-update.gschema.xml +++ b/schemas/org.gnome.shell.extensions.fedora-update.gschema.xml @@ -126,7 +126,7 @@ </key> <key name="package-info-cmd" type="s"> - <default>"xdg-open https://packages.fedoraproject.org/"</default> + <default>"xdg-open https://packages.fedoraproject.org/pkgs/%1$s/%2$s"</default> <summary>Command to show info for a package.</summary> <description>Can be used as a string template with attributes.</description> </key>