Review of "Brightness utilities" version 5

Details Page Preview

Utilities for controlling brightness of external displays and controlling nightlight temperature

Extension Homepage
https://github.com/slaclau/brightness-utils-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Move line 12-31, 48 (quicksettings/BrightnessSliders.js) to the class using it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 2. Timeout should be removed on destroy (line 111, 502 quicksettings/BrightnessSliders.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Please use `TextDecoder` instead of `byteArray` (line 2 services/shell.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder 4. Please remove `services/timer.js`. We have both `setTimeout()` and `clearTimeout()` by default on GNOME Shell 45.